fixed a few bugs in isAbout and source_variable keys in json sidecar files

incf-nidash / PyNIDM

Other

21 stars 31 forks source link

fixed a few bugs in isAbout and source_variable keys in json sidecar files #380

Closed dbkeator closed 1 year ago

yarikoptic commented 1 year ago

overall - without adding tests demonstrating the issue being fixed, there is high chance of playing ping-pong with fixes going back and forward fixing for some use cases and breaking for the other.

dbkeator commented 1 year ago

@yarikoptic Turns out I already wrote tests for the two variants of the json sidecar files: https://github.com/incf-nidash/PyNIDM/blob/master/tests/experiment/test_map_vars_to_terms.py . Will refactor the map_variable_to_terms code as we discussed and update the tests...