search

incf-nidash / PyNIDM

Other
21 stars 31 forks source link

fixed bug with BIDS sidecar files when supplied by user and updated tests #394

Closed dbkeator closed 8 months ago

dbkeator commented 8 months ago

The map_vars_to_terms utility in pynidm was modifying json sidecar (mapping) files when they were supplied with a BIDS dataset and the user selected to do no annotations. This is fixed along with a new test / modified tests to accommodate this change.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (0237ab3) 34.37% compared to head (fe42841) 34.44%.

Files Patch % Lines
src/nidm/experiment/Utils.py 25.00% 5 Missing and 1 partial :warning:
...nidm/experiment/tools/nidm_affinity_propagation.py 0.00% 1 Missing :warning:
.../experiment/tools/nidm_agglomerative_clustering.py 0.00% 1 Missing :warning:
src/nidm/experiment/tools/nidm_gmm.py 0.00% 1 Missing :warning:
src/nidm/experiment/tools/nidm_kmeans.py 0.00% 1 Missing :warning:
src/nidm/experiment/tools/nidm_linreg.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #394 +/- ## ========================================== + Coverage 34.37% 34.44% +0.07% ========================================== Files 52 52 Lines 6843 6849 +6 Branches 1674 1675 +1 ========================================== + Hits 2352 2359 +7 + Misses 4322 4318 -4 - Partials 169 172 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.