incf-nidash / nidmresults-fsl

A python library to export FSL's feat results to NIDM-Results
http://nidm.nidash.org/specs/nidm-results.html
MIT License
3 stars 11 forks source link

Small Bug fix #139

Closed TomMaullin closed 6 years ago

TomMaullin commented 6 years ago

What does this PR do?

Hi @cmaumet ,

I just found a really small bug that meant that the Effect degrees of freedom were not being recorded for the F statistic maps. It has been rectified by only changing 2 lines and the changes made here were fairly straightforward. Does this seem okay to merge to you?

PR submission checklist

pep8speaks commented 6 years ago

Hello @TomMaullin! Thanks for submitting the PR.

cmaumet commented 6 years ago

Thanks for catching this @TomMaullin. I am happy to merge. It's just a bit worrying that the tests did not catch this up.

Are those PEP8 errors new? I don't remember having "invalid escape sequence" in the past.

TomMaullin commented 6 years ago

From what I can see, it seems like there has been an update on pep8 3 months ago and the python 3.7 version is stricter than the older versions.

cmaumet commented 6 years ago

Thanks for tracking this down. I've created issue https://github.com/incf-nidash/nidmresults-fsl/issues/141 to remember to update the code to comply with new PEP8 rules.