Closed TomMaullin closed 6 years ago
Hello @TomMaullin! Thanks for submitting the PR.
nidmfsl/fsl_exporter/fsl_exporter.py
, following are the PEP8 issues :
Line 138:34: W605 invalid escape sequence '\d' Line 273:22: W605 invalid escape sequence ')' Line 279:22: W605 invalid escape sequence '.' Line 279:24: W605 invalid escape sequence '\d' Line 279:27: W605 invalid escape sequence ')' Line 279:41: W605 invalid escape sequence '\d' Line 303:22: W605 invalid escape sequence '.' Line 303:24: W605 invalid escape sequence '\d' Line 303:27: W605 invalid escape sequence ')' Line 303:41: W605 invalid escape sequence '\d' Line 452:17: W605 invalid escape sequence '\d' Line 789:23: W605 invalid escape sequence '\d' Line 789:26: W605 invalid escape sequence ')' Line 794:34: W605 invalid escape sequence '\d' Line 794:38: W605 invalid escape sequence ')' Line 883:18: W605 invalid escape sequence ')' Line 883:29: W605 invalid escape sequence '\d' Line 943:18: W605 invalid escape sequence ')' Line 943:31: W605 invalid escape sequence '\d' Line 951:14: W605 invalid escape sequence ')' Line 951:27: W605 invalid escape sequence '\d' Line 1086:24: W605 invalid escape sequence '\d'
Thanks for catching this @TomMaullin. I am happy to merge. It's just a bit worrying that the tests did not catch this up.
Are those PEP8 errors new? I don't remember having "invalid escape sequence" in the past.
From what I can see, it seems like there has been an update on pep8 3 months ago and the python 3.7 version is stricter than the older versions.
Thanks for tracking this down. I've created issue https://github.com/incf-nidash/nidmresults-fsl/issues/141 to remember to update the code to comply with new PEP8 rules.
What does this PR do?
Hi @cmaumet ,
I just found a really small bug that meant that the Effect degrees of freedom were not being recorded for the F statistic maps. It has been rectified by only changing 2 lines and the changes made here were fairly straightforward. Does this seem okay to merge to you?
PR submission checklist