inch-ci / inch_ci-web

Web frontend for Inch CI
http://inch-ci.org/
MIT License
139 stars 20 forks source link

Suggests specification of return type of setters (#meth=) #109

Closed paddor closed 8 years ago

paddor commented 8 years ago

The return value of those kinds of method is enforced by ruby to be exactly the object given as parameter. Maybe you could deduce it from the parameter's documentation or just stop suggesting this on setter methods.

rrrene commented 8 years ago

Good catch! I will try to update Inch over the holidays :+1:

paddor commented 8 years ago

Thank you. :-) Enjoy the holidays!

paddor commented 8 years ago

Any news on this?

Also, it seems like refreshing doesn't work anymore...

rrrene commented 8 years ago

Hi, I'm on it. Server clogged up somehow. :scream:

Had a nasty cold over the holidays and then ... forgot. Sorry. :sweat:

paddor commented 8 years ago

Oh no, very sorry to hear that.

Take your time. :-)

paddor commented 8 years ago

Thanks a lot! :+1:

rrrene commented 8 years ago

Hey, this is not live yet. I am re-opening the issue to not forget it.

(I have to make a new release of Inch and point Inch CI to it. Won't get that done today, unfortunately.)

paddor commented 8 years ago

Oops :sweat_smile: All I did was test is the Refresh button and verify whether Inch CI suggests setting a @return on setter methods. And it doesn't, which I like. So what else is there to come?

paddor commented 8 years ago

Any updates?

rrrene commented 8 years ago

Not sure, I am a bit out of the loop on my Github Issues as there is currently soooo much work. :scream:

Does Inch CI now behave the way you suggested?

paddor commented 8 years ago

I just checked! Yes, it does. No more suggestions for return type on #foo= methods. Thank you!