search

incidentist / the_tuul

Make a decent karaoke video from any song in about 10 minutes.
https://the-tuul.com
17 stars 4 forks source link

Add automatic [instrumental], [intro] and [outro] #4

Closed incidentist closed 10 months ago

incidentist commented 2 years ago

Detect long stretches without singing, and add [INTRO], [INSTRUMENTAL] and [OUTRO] screens as appropriate.

WicCaesar commented 1 year ago

Musixmatch tags these with hashes and the corresponding part of the music before a set of verses. For instance:

#PRE-CHORUS
Too high, can't come down
It's in the air and it's all around
Can you feel me now?

#CHORUS
With a taste of your lips, I'm on a ride
You're toxic, I'm slippin' under
With a taste of a poison paradise
I'm addicted to you
Don't you know that you're toxic?

They have the following structures: #INTRO #VERSE #PRE-CHORUS #CHORUS #HOOK #BRIDGE #OUTRO. You don't need all those, right? #INSTRUMENTAL is a good one.

I know you're trying to implement it automatically, but I ask you to consider not to apply it automatically to every video; leaving the choice to the user if they want those tags on screen. I wouldn't like them to appear automatically in lyrics that are not in English, for instance. The word "outro" in Portuguese means "other", no one would associate it with the ending of a song, we simply don't have a name for it.

And while you don't implement automatic detection, I think you could just guide the user to apply it along with the lyrics, since we're editing them anyway. So when the instrumental part begins, the user just hits the spacebar on the line that says #INSTRUMENTAL (they themselves wrote there, minimising any risk of "misdetection").

incidentist commented 1 year ago

@WicCaesar I'm not familiar with Musixmatch but yes, currently you can add these markers yourself in the lyrics and hit spacebar/enter at the right times, and it'll look good. This feature would be to do it automatically, reducing the amount of extra stuff I need to add when I copy/paste the lyrics from genius.com :P .

But it would definitely have to be optional. At some point there needs to be a "general options" screen or something, because as features get added, people are going to want more configurability (and that's a good thing to want!). So I can imagine a checkbox to disable the feature completely, as well as a few other options for configuring the length of time that counts as an [INSTRUMENTAL], for instance.

The word "outro" in Portuguese means "other", no one would associate it with the ending of a song, we simply don't have a name for it.

Interesting! Eventually I want to have translations for the interface, but that will be tricky in cases where there is no direct translation.

WicCaesar commented 1 year ago

I'm not familiar with Musixmatch

The controls in their synchronisation screen are so good! I was surprised.

https://i.imgur.com/VpTlywt.png This white button with a down arrow is equivalent to the space bar at Tüül.

https://i.imgur.com/aA5IIfe.png I love these + - buttons that allow us to fine adjust the starting of a new line. You can just click any line to go to that exact part of the music.