search

inciteco / tug-of-war

0 stars 0 forks source link

You can apparently play yourself #7

Closed aaronbuchanan closed 7 years ago

aaronbuchanan commented 7 years ago

what should happen if you open two tabs and join within the 10 second time period? you are in two lobbies currently... how much work do we want to spend on this corner case?

aaronbuchanan commented 7 years ago

talked to brett, I will: – assume a game is stale if the player hasn't posted an update in 10 seconds – have players post heartbeat updates every 1 second

inciteco commented 7 years ago

@aaronbuchanan Did you add this? Will close if so...

aaronbuchanan commented 7 years ago

not yet! I think this is low-priority?

inciteco commented 7 years ago

agreed. Low.

aaronbuchanan commented 7 years ago

I pushed something that should fix this yesterday, with the only exception being if you actually open two windows then you can still play yourself, but a closed connection should properly remove a user from playing. I'll test and confirm

inciteco commented 7 years ago

Cool. The two windows thing is fine. And yes we like a closed connection removing a player from playing.

aaronbuchanan commented 7 years ago

cool, this seems to be working properly, going to close