inclement / vivarium

A dynamic tiling Wayland compositor using wlroots
GNU General Public License v3.0
367 stars 13 forks source link

[Question] device name to set tap-to-click on touchpad. #116

Closed ahmadraniri1994 closed 2 years ago

ahmadraniri1994 commented 2 years ago

Hello, does vivarium support tap-to-click ? If does, how to configure it ? I tried to enter my touchpad device name I got it from "libinput list-devices", but it doesn't work. Thanks

inclement commented 2 years ago

I think the "fingers" option for the [[libinput]] click_method in the config file does this, but I haven't tested it. I'll try to test later, I've been meaning to try to enable it on my laptop.

ahmadraniri1994 commented 2 years ago

Thanks for replying, so where do we get device-name from ? Is it from sudo libinput list-devices ?

ahmadraniri1994 commented 2 years ago

I have these for libinput configuration and tap-to-click still doesn't work :


# Example libinput-config for a popular trackball:
device-name = "SynPS/2 Synaptics TouchPad"
scroll-method = "2-finger"
#scroll-button = 8
middle-emulation = true
left-handed = false
natural-scroll = true
disable-while-typing = false
click-method = "fingers"```
inclement commented 2 years ago

Yes, the device name from libinput list-devices should work. I'm not sure why it isn't working for you, it could be that the "fingers" method doesn't do what I thought or there could be a bug in Vivarium in setting this config. I'll try to test it on my own laptop at the weekend - it looks like I have exactly the same touchpad device name so hopefully I can make that work.

ahmadraniri1994 commented 2 years ago

I'll try to test it on my own laptop at the weekend

I'll wait, thanks.

flaviozavan commented 2 years ago

It looks like this feature can be toggled with libinput_device_config_tap_set_enabled, which isn't called anywhere in the code. It should be almost trivial to introduce support for this, as well as for all the other options libinput supports

ahmadraniri1994 commented 2 years ago

It's a bit out of topic, while waiting for the result, I made an attempt to show vivarium's workspaces on yambar bar, it's successful. You may check this : Yambar for vivarium.

inclement commented 2 years ago

Thanks @flaviozavan, I somehow missed this important libinput option when I first set up the libinput code.

I've made PR #117 which adds the tap-to-click option, and tested that it works on my own trackpad, example config given on the PR. @ahmadraniri1994 would you be able to test that PR to double check I haven't missed something? No worries if that's a problem for you, I've tested that it works and seems good to merge.

lidgnulinux commented 2 years ago

@inclement Thanks, I'll try that.

lidgnulinux commented 2 years ago

Confirmed, tap to click is usable now, thanks @inclement .

inclement commented 2 years ago

Great, thanks @lidgnulinux for the report and for checking the fix.

Also delighted that Yambar works for displaying workspaces!

ahmadraniri1994 commented 2 years ago

Wow, it works, thanks @inclement .