search

inclement / vivarium

A dynamic tiling Wayland compositor using wlroots
GNU General Public License v3.0
372 stars 13 forks source link

AUR Package #3

Closed proudmuslim-dev closed 3 years ago

proudmuslim-dev commented 3 years ago

Just came across this project and figured I'd open an issue for an AUR package, as packaging it there would bring obvious benefits

lmartinez-mirror commented 3 years ago

@proudmuslim-dev Hi, I'm currently working on packaging this for the AUR. I'll be sure to post here again when it's finished.

proudmuslim-dev commented 3 years ago

@lmartinez-mirror Awesome, thank you

lmartinez-mirror commented 3 years ago

Got a compiled binary from the PKGBUILD, but it doesn't run. I wind up with this error:

vivarium: symbol lookup error: vivarium: undefined symbol: wlr_xdg_surface_for_each_popup

@inclement Do you know what might be happening here? I'm using wlroots 0.12.0; master branch will not compile.

inclement commented 3 years ago

Interesting, I'm not sure what's up here. You'll definitely need wlroots 0.12.0 as there are significant breaking changes between versions, but I don't see why that symbol should cause problems.

What is the output of nm --format sysv -D /path/to/libwlroots.so | grep wlr_xdg_surface_for_each_popup? And indeed, what is that path to wlroots? I'm developing on arch with the latest wlroots 0.12.0-1 package, which has this symbol.

lmartinez-mirror commented 3 years ago

Sorry, I forgot I use wlroots-git on my personal system, so of course it won't run!

nm and grep successfully find this symbol in vivarium in a clean chroot. I'll upload the PKGBUILD here for anyone to test before I submit it to the AUR.

inclement commented 3 years ago

Ah great, thanks, happy to test the PKGBUILD.

lmartinez-mirror commented 3 years ago

PKGBUILD.zip

inclement commented 3 years ago

Works great. May I suggest s/wlroots/wayland in the pkgdesc?

< pkgdesc="A dynamic tiling wlroots compositor inspired by xmonad"
---
> pkgdesc="A dynamic tiling wayland compositor inspired by xmonad"
lmartinez-mirror commented 3 years ago

Sure thing, I'll make that change before I push.

@proudmuslim-dev Tagging because I know you were interested in a PKGBUILD, it'll go live soon.

lmartinez-mirror commented 3 years ago

AUR package is live. I'll create another PKGBUILD when Vivarium hits its first stable release. This issue can be closed.

proudmuslim-dev commented 3 years ago

@lmartinez-mirror Awesome, closing the issue now

ProjectInfinity commented 3 years ago

How would you go about this now that arch ships wlroots 0.13? The pkgbuild seem to fail for me.

inclement commented 3 years ago

I've added an AUR comment explaining why it's failing, and a couple of workarounds.

In short: https://github.com/inclement/vivarium/pull/43 should work with wlroots 0.13 but isn't well tested yet, or if you manually build then meson is configured to automatically download and build against a compatible wlroots version (currently 0.12.0). The AUR package should work again as soon as #43 is merged, but it's been delayed a bit as I've focused recently on damage tracking.

lmartinez-mirror commented 3 years ago

Thanks for the heads up, I was fixing to raise a new issue about this. I'll update it as soon as it's merged.

inclement commented 3 years ago

Sorry for the delay there, took longer than expected due to focusing on damage tracking (which works now!).

I've just merged #43 which should mean everything works fine with wlroots 0.13.0 now.