search

inclement / vivarium

A dynamic tiling Wayland compositor using wlroots
GNU General Public License v3.0
367 stars 13 forks source link

Additional input options #91

Closed flaviozavan closed 2 years ago

flaviozavan commented 2 years ago

Adds the possibility to configure disabling the input device while typing and allows for choosing the click method. Both of which are useful for touchpads

Two points to consider:

  1. I wasn't sure if the way I set the default values is within expectations or not;
  2. I couldn't figure out how to run the tests.
inclement commented 2 years ago

I wasn't sure if the way I set the default values is within expectations or not;

I think ideally these should be pulled out to some centralised defaults list, but I hadn't thought about it before (and it didn't come up with the other libinput values) so there isn't an obvious one right now. Happy to merge as-is and change it later, I've made #92 to think about it.

That said, I think there's a case for making both options disabled by default - dwt in particular can be annoying for some (although essential for others, it's just subjective and hardware-dependent). Still happy to merge as-is, but I might push to change the defaults later.

flaviozavan commented 2 years ago

Addressed the comments. About the defaults. I don't really care about the ones I chose, they were simply my touchpad's default and I wanted to change them. I made it default to none/disabled now. The centralized defaults idea seems like a pretty good idea.

I figured out how to run the tests locally this time. So they should pass now.

inclement commented 2 years ago

Great, thanks again.