Closed rishabraghav closed 10 months ago
Someone is attempting to deploy a commit to a Personal Account owned by @inclinedadarsh on Vercel.
@inclinedadarsh first needs to authorize it.
I have left a comment in issue #14 for now, i'm keeping it as it is.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
timeloom | ✅ Ready (Inspect) | Visit Preview | Oct 19, 2023 3:40pm |
@inclinedadarsh Hi there! I've updated the validation for the login page as well. I was wondering, if someone creates a username using the signup page validation, that mean they're the only ones who can log in successfully? If someone fails the validation during signup, that mean they won't be able to log in at all? It seems to me that we might not need to validate the username at login because the valid usernames are already stored in the database. What are your thoughts on this?
This makes sense @rishabraghav . Let's do one thing, let's remove that validation and the validation message altogether. If this makes sense to you then go ahead and make those changes.
Also, if you have any more discussion around it, I would love to hear.
Thanks!
Hey there @inclinedadarsh. I have updated username validation on the login page. Will this work? what do you think?
This looks good to me. Thanks a lot for contributing @rishabraghav
It would be great if you can give this repo a star :star:
Thanks!
"Username can only contain letters, numbers, and underscores. It must be between 3 and 16 characters long, and it cannot start with a full stop."
Fixes #14
cannot start with a full stop
can only contain letters, numbers, and underscores