Closed rjwignar closed 10 months ago
Someone is attempting to deploy a commit to a Personal Account owned by @inclinedadarsh on Vercel.
@inclinedadarsh first needs to authorize it.
Heyy @rjwignar Let's skip the bg-grid.png
for now, I'll open a new issue for that.
It seems like you're done working on this one, if so, please mark it for review. Thanks!
I think I've marked it for review now. Please let me know if it's the same on your end.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
I experimented with the Next Themes solution provided on a test branch and the solution only provides light/dark mode support similar to the media strategy used by TailwindCSS. I don't think the Next Themes strategy is required to refactor the code.
However, I can look into cleaning up globals.css
so that styles are specified only once.
Alternatively, I can use the light/dark themes provided by Next Themes. However, this will likely replace the light/dark mode styles we created.
Please let me know which you would like me to do.
Yesterday I moved the light
mode styles into the root
styling and removed duplicate stylings from globals.css
.
Please let me know if this refactor is sufficient, or if you would like to use one of Next Themes
' light/dark mode presets instead.
Thanks for the feedback! I plan to work on this over the weekend. I'll request another review when ready.
I've made the UI changes requested. Please let me know what you think!
This fixes #9
Changes were tested by running Timeloom using
npm run dev
(dev
script)Summary of Changes
Modified the following files:
app/globals.css
app/page.tsx
dark:{class}
to apply them in dark modedark:{class}
to apply it in dark modecomponents/Footer.tsx
Link
component in Footerdark:{class}
to apply them in dark modecomponents/ui/button.tsx
dark:{class}
to apply them in dark modetailwind.config.ts
media
(for OS preference) strategy alongside existingclass
(manual) strategy, as per https://tailwindcss.com/docs/dark-modedarkMode: ["media", "class"],
enables both theOS preference
strategy andclass
strategydarkMode: ["class", "media"],
is used, only theclass
strategy is enabledProspective Changes (Pending Maintainer approval)
bg-grid.png
for Light Modebg-grid.png
and add it to the assets.