search

inclinedadarsh / timeloom

Document your technical journey on the activity timeline-style page and showcase it to the world!
https://timeloom.vercel.app
MIT License
15 stars 3 forks source link

[FEATURE REQUEST] Light mode #9

Closed inclinedadarsh closed 10 months ago

rjwignar commented 10 months ago

I would like to work on this feature. Please assign it to me.

inclinedadarsh commented 10 months ago

Go ahead @rjwignar I have assigned this to you.

I'm here for any assistance you need. Thank you for your interest!

rjwignar commented 10 months ago

Thank you. So far I've extended the UI to use light/dark mode according to the user's system preferences. Right now I'm working on the light mode styling. image

I should have a PR later today.

However, I'm not sure of the best way to proceed with the grid image for light mode: image

I understand the white grid image is from @/assets/bg-grid.png, but I can't seem to modify the image color using code. Do you know of a way to do this without adding a new image to the project?

inclinedadarsh commented 10 months ago

This is looking good @rjwignar

For the bg-grid.png, we can do 2 things, choose whichever option you like:

  1. Leave it for now & open a separate issue for that.
  2. I'll give you access to the Figma, you make a light-mode version of it and use it in the assets as well. Write logic to show respective versions when in light or dark mode.
rjwignar commented 10 months ago

I can't guarantee if I can replicate the exact effect you have in the original, but I can try making a light-version of it using the figma and include it in my PR.

Then depending on how you like it we can keep it remove it from the PR. If sharing the figma requires an email you can share it to this email address: rjwignarajah@myseneca.ca