search

include-davis / Include-CMS

In-house CMS system for future clients to use and deploy for free
MIT License
1 stars 1 forks source link

Feat/crud collections #97

Closed winzamark123 closed 1 month ago

winzamark123 commented 2 months ago

90 No server actions yet and media datalib and route seems redundant

Austin2Shih commented 2 months ago

For the future, split up your work. If you make one PR for like one file, it's fine. Too much is not as fine lol. Don't put it all into one huge PR cuz it's more work to change for you and if you mess up once, you won't be corrected until you've already propagated the error to the rest of the code.

Also, you did media and collection datalib in the same PR. This easily could've been split up. Also make sure to test your code before you put up a PR. From my quick look through the code, I know it won't work.

If you have trouble testing, ask in the chat and I'm happy to help. Testing locally will save us tons of time so please try to do that. At least test basic functionality but edge cases being tested is great too.