include-dcc / include-linkml

LinkML Schema for INCLUDE DCC
https://include-dcc.github.io/include-linkml/
MIT License
3 stars 4 forks source link

Develop enums for Study, Biospecimen, Data File, Assay and add ontology terms #108

Open lopierra opened 1 year ago

lopierra commented 1 year ago

Add/review/finalize enums/ontology terms for the following Study/Dataset fields (see notes here):


Pierrette's comments: For Biospecimen/Assay/DataFile, we have discussed EDAM, OBI, etc. Sample Type, File Type, etc.

Currently, we have a controlled vocabulary, but using a pre-existing ontology might allow us to have more relationships/hierarchies, e.g., between Data Categories & Types. Maybe we could annotate Experimental Platform and then have a search widget for users to search parent categories?

lopierra commented 4 months ago

Application ontology will also be very useful for the new Study/Datatset fields. Please see the yellow highlighted cells in this sheet.

lopierra commented 4 months ago

Related to #159

twhetzel commented 4 months ago

Matt and I have discussed two options for including enums from ontology terms, (1) an explicit enumeration of terms in enum definitions or (2) referencing subsets of terms defined in an external Application Ontology.

Currently the decision is for (1) to define a fixed set of terms in the schema in advance because the LinkML docs says "this works well if the vocabulary is known in advance and it is a relatively small number of terms" [1].

A small example for sample type is in this branch

The notes from our discussion are in the INCLUDE gDrive here.

Two open questions are:

[1] https://linkml.io/linkml/faq/modeling.html#how-do-i-constrain-the-value-of-a-slot-using-an-ontology-or-vocabulary