includeos / IncludeOS

A minimal, resource efficient unikernel for cloud services
https://www.includeos.org
Apache License 2.0
4.92k stars 363 forks source link

Enable Musl 1.2.5's new malloc #2277

Open alfreb opened 2 months ago

alfreb commented 2 months ago

It's supposedly faster, but issues were encountered with this enabled during upgrade to 1.2.5. See discussion in #2251.

MagnusS commented 2 months ago

To test with new malloc, remove "--with-malloc=oldmalloc" from: https://github.com/includeos/IncludeOS/blob/v0.16.0-release/deps/musl/default.nix#L37 and https://github.com/includeos/IncludeOS/blob/v0.16.0-release/deps/musl-unpatched/default.nix#L20

With malloc-ng, the kernel currently seems to enter a reboot cycle in libc init, here: https://github.com/includeos/IncludeOS/blob/master/src/platform/x86_pc/init_libc.cpp#L178

Control never comes back to kernel_main.