search

includeos / acorn

Acorn Web Server Appliance, built with IncludeOS
Apache License 2.0
93 stars 13 forks source link

Augmented file router.hpp #16

Closed RicoAntonioFelix closed 8 years ago

RicoAntonioFelix commented 8 years ago

Changes

alfreb commented 8 years ago

Hi @RicoAntonioFelix thanks for the updates! I'm really glad to see we found common ground regarding the comments :-) One thing: I think we should avoid using macros as shorthand for code: https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es30-dont-use-macros-for-program-text-manipulation

We do use them for the debug-output, but that's out of necessity; it's the only way I know of to get things completely non-existent before they hit the compilers. CHECK/CHECKSERT/INFO could probably have been made using variadic templates - but for e.g. debug it's trickier as we need it to eventually hit printf, with the formatting notation, the VA_ARGS stuff etc. I'd be open to improvements to these, but it's not a big priority. Otherwise 👍

RicoAntonioFelix commented 8 years ago

Don't merge... WIP