Bugfixes to stabilize latest application version

inclusion-international / speech-jokey

A speech synthesis software with integration of several TTS APIs, SSML support and optimizations for users with motor impairment. (course ASSIST HEIDI WS2023 and SS2024)

MIT License

1 stars 0 forks source link

Bugfixes to stabilize latest application version #3

Closed HackXIt closed 3 months ago

HackXIt commented 3 months ago

[x] File selection doesn't actually open file 908b0e93c48821a0eb8e6175479a80de618c8597
[x] Lockfile was not properly update to use latest kivyMD 4eaf020cd2e3000cbc67c2333f6f909410b2e855
[x] fbind error if selected API is actually None and settings attempts to add it c915298dfffe1407d8d7e6d58f6c43c703ff1dff
[x] Use lazy formatting on all calls to log functions d5c126cd000ec0bc2c5373d7099df80c37331725

deinhofer commented 3 months ago

When opening file the self.opened_file is not set correctly:

It should be the following, otherwise a subsequent save action does not work:

        if self.last_path is not None and os.path.isfile(os.path.join(self.last_path, self.opened_file)):
            self.opened_file = os.path.join(self.last_path, self.opened_file)
            self.load_textfile(self.opened_file)

deinhofer commented 3 months ago

When opening failed due to unsupported file type, everything should be reset: e.g.:

    def load_textfile(self, file: str):
        file_ext = file.split('.')[-1]
        if file_ext not in self.supported_text_files:
            # if file extension is not supported, don't try to open it and reset everything
            self.opened_file = None
            self.ids.text_main.text = ""
            log.error(f"{self.__class__.__name__}: Unsupported file type: {file_ext}")

deinhofer commented 3 months ago

When clicking on ExampleAPI, the screen does not open:

deinhofer commented 3 months ago

ok, thanks. I will merge it for now, so that the students can already work on it. But please continue to commit, if you have a new fix.