search

inclusive-design / AChecker

Automated interactive Web content accessibility checker.
https://achecker.ca
GNU General Public License v2.0
70 stars 61 forks source link

AChecker using PHPMailer v5.2.7 #36

Closed tassoman closed 10 years ago

tassoman commented 10 years ago

This branch uses PHPMailer tag v.5.2.7 as submodule

tassoman commented 10 years ago

Well, I have also another improvement in master branch but I don't know how to get done this pull request and relative commits :scream: I definetively need some help in git and githubbing :hammer:

gregrgay commented 10 years ago

We can't accept a sub module replacement of the original phpmailer. It has to be a stable released version with the actual files. If you want to include the files from the tag you have specified, we'll consider adding those.

When working on specific fixes etc, create a separate branch for set of changes and submit the changes as a pull request.

tassoman commented 10 years ago

Sorry but I can't understand why you don't want use submodules to manage external libraries like this option is supposed to be useful to. Can't understand twice because library version injected into project is steady at 1.0.2. So sad. Btw thank you for branch tip.