search

inclusive-design / AChecker

Automated interactive Web content accessibility checker.
https://achecker.ca
GNU General Public License v2.0
69 stars 61 forks source link

AChecker with PHPMailer 5.2.7 source code included #37

Closed tassoman closed 10 years ago

cindyli commented 10 years ago

The PHPMailer source code contains all the language translation files, documentation etc., which can be cleaned up. It would be great to keep libraries as minimal as possible. It will help to reduce the size of AChecker release bundle. This is also one case that using git submodule is not ideal.

As you may have known, PHPMailer is in charge of mail communication. Did you test to make sure the mailing system works fine with the upgrade? Thanks.

tassoman commented 10 years ago

Hello, I think documentation should be kept in place because of smtp vs. sendmail configuration for servers would be different.

Would be better integrating the ability of selecting SMTP config vs Sendmail during AChecker Installation process. Language files are there because of AChecker is supporting multilanguages.

PHPMailer is extended by your custom class that wasn't touched (only moved ../ ) so I suppose it works. No php errors/exception thrown.

I have no way to test the full process of sending mail until i got my application to staging because of security limits of organization's intranet.

cindyli commented 10 years ago

Thanks for sharing your thoughts.

The documentation at the official PHPMailer site is a better place to look around rather than keeping all doc as part of a production AChecker.

In terms of language files, before you decided to leave them in there, did you figure out whether they are usable or hooked up by AChecker.

I understood your difficulty of testing a mailing system. Once this pull request is clean and ready, we'll find some time to test it.

Thanks.

tassoman commented 10 years ago

Closed by #39