Conditions for highlighting menu tabs on clicking sub-menus as well

inclusive-design / AChecker

Automated interactive Web content accessibility checker.

https://achecker.ca

GNU General Public License v2.0

69 stars 61 forks source link

Conditions for highlighting menu tabs on clicking sub-menus as well #47

Closed tejasshah93 closed 10 years ago

tejasshah93 commented 10 years ago

Reference Issue: http://atutor.ca/atutor/mantis/view.php?id=4917 Before: Menu tab highlighting disappears on clicking sub-menu tabs of any particular menu. After fix: The top tab menu highlighting remains as desired even if a sub-page is visited as in 'Users' tab.

cindyli commented 10 years ago

A php warning is reported from ur code:

Warning: Illegal string offset 'url' in /Users/cindyli/Development/AChecker/themes/default/include/header.tmpl.php on line 123

tejasshah93 commented 10 years ago

@cindyli: yes, I reviewed the code once again.. that warning was occurring because I missed a condition to validate if 'url' is NULL or not. I've modified the condition accordingly.. Please confirm the same.

cindyli commented 10 years ago

Thanks for the contribution, Tejas.