search

inclusive-design / AChecker

Automated interactive Web content accessibility checker.
https://achecker.ca
GNU General Public License v2.0
70 stars 61 forks source link

Call-time pass-by-reference has been deprecated in PHP 5.3 #50

Closed gtirloni closed 9 years ago

gtirloni commented 9 years ago

This removes the call by reference so Achecker is able to work with PHP 5.4.

cindyli commented 9 years ago

Thanks for looking into this, @gtirloni. My comments,

Some changed files are third party libraries. Instead of modifying them directly that will require us to maintain the modified versions ourselves in the future, we can try to upgrade those libraries first:

Savant: http://phpsavant.com/docs/ Simple HTML DOM: http://simplehtmldom.sourceforge.net/ PclZip: http://www.phpconcept.net/pclzip/

PHPCache was a third party library but had been modified by us. Can you add the goal of your modification into the top comment explanations, after line 5.

gtirloni commented 9 years ago

I'll look into that and keep you posted. Thanks.

gtirloni commented 9 years ago

Closing PR in favor of #51 . Thanks Cindy!