search

inclusive-design / AChecker

Automated interactive Web content accessibility checker.
https://achecker.ca
GNU General Public License v2.0
70 stars 61 forks source link

ACHECKER-5: Removing Deprecated Call-By-Reference PHP Codes #85

Closed VictorAlagwu closed 6 years ago

VictorAlagwu commented 6 years ago

Removing Deprecated Call-By-Reference PHP Codes

https://issues.fluidproject.org/projects/ACHECKER/issues/ACHECKER-5

cindyli commented 6 years ago

Seems this class is still using the old constructors: include/lib/tfpdf/font/unifont/ttfonts.php

cindyli commented 6 years ago

Line 820 and 1006 in include/securimage/WavFile.php still use deprecated passing by reference (&$). Please search thru the code base to address all. Thanks.

cindyli commented 6 years ago

I wonder why the recently upgraded secureImage library uses deprecated passing by reference. Doesn't it claim it supports PHP7?

VictorAlagwu commented 6 years ago

Yes, it does support PHP 7

cindyli commented 6 years ago

Testing this branch with PHP 7 shows the theme is not applied:

screen shot 2018-06-27 at 10 44 26 am

Also, a PHP error is reported: Invalid argument supplied for foreach() in ../AChecker/themes/default/include/header.tmpl.php on line 120

I suspect these issues are caused by the fact that the savant2 template system doesn't support PHP 7. What do you think?

VictorAlagwu commented 6 years ago

Yes, it is as a result of Savant2 not supporting PHP 7, I would include a little patch for it to work,for the main time, till I complete the task on changing the template engine