search

inclusive-design / AChecker

Automated interactive Web content accessibility checker.
https://achecker.ca
GNU General Public License v2.0
69 stars 61 forks source link

ACHECKER-6 #92

Closed VictorAlagwu closed 5 years ago

VictorAlagwu commented 6 years ago

Completed Requirement PHP 7.0+

VictorAlagwu commented 5 years ago

The issue with exporting pdf is resolved, PR is ready for testing.

cindyli commented 5 years ago

vendor/ directory is submitted in the pull request. Please remove it if this is a mistake.

VictorAlagwu commented 5 years ago

Ready for review and merging

cindyli commented 5 years ago

One bug I found by comparing the validation result of "http://achecker.ca" between my local achecker deployed with the latest achecker master and achecker.ca is:

The master:

screen shot 2018-07-17 at 4 56 43 pm

achecker.ca:

screen shot 2018-07-17 at 4 56 53 pm

If you have a look on what should trigger the report on Checker 187, it really should not be reported.

This issue should be debugged to find out if it's related to the Simple HTML Dom library that hasn't been upgraded, or a bug in our code.

VictorAlagwu commented 5 years ago

Yeah, I notice that as well, It is probably a bug in the code, will add that to jira

Update It is, as a result of me removing some pass by reference variables, will send a new pull request to rectify this.