search

inclusive-design / idrc

Website for the Inclusive Design Research Centre.
https://idrc.ocadu.ca
BSD 3-Clause "New" or "Revised" License
4 stars 9 forks source link

chore(cms): add All Standards project page #1001

Closed greatislander closed 3 months ago

netlify[bot] commented 4 months ago

Deploy Preview for idrc ready!

Name Link
Latest commit 7a50ce83dfd320d2f083248cc46208d08531509f
Latest deploy log https://app.netlify.com/sites/idrc/deploys/66b4b4095d76cd00080ffd1f
Deploy Preview https://deploy-preview-1001--idrc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chosww commented 4 months ago

Hey @greatislander, thanks for working on this. I noticed that you have translated French URL into French (projects into projets), and that caused rendering a link back to Projects page in French version only, due to line: https://github.com/greatislander/idrc/blob/c81d86e30b7dd16cc55c56f8b79a3204daced9cb/src/_includes/partials/components/page-header.njk#L4.

I think we need to update the logic to include French translation for "projects" or don't translate url parts into French.

greatislander commented 4 months ago

Hey @greatislander, thanks for working on this. I noticed that you have translated French URL into French (projects into projets), and that caused rendering a link back to Projects page in French version only, due to line: greatislander/idrc@c81d86e/src/_includes/partials/components/page-header.njk#L4.

I think we need to update the logic to include French translation for "projects" or don't translate url parts into French.

Good catch, @chosww. Can you file a PR to add the check for the French URL as well?