search

inclusive-dev-tools / woke

✊ Detect non-inclusive language in your source code.
https://medium.com/@caitlinelfring/woke-437880c3de64
MIT License
0 stars 0 forks source link

Fix disableVersionCheck in package.json in vscode-woke repository #18

Closed mkcomer closed 3 years ago

mkcomer commented 3 years ago

Currently, the vs-code woke extension doesn't manage the installation of woke, you need to install it yourself and it will use whatever it can find in your $PATH, or what you define in the extension setting woke.executablePath.

disableVersionCheck in the package.json is supposed to warn you if your local (or container) version is outdated when running your vs-code-extension.

Fix disableVersionCheck – it is supposed to warn you if your woke version is outdated when running your vs-code extension. I did not find this to work. I ran VS Code extension on woke 0.9.0 and woke is on version 0.10.0 - nothing prompted me to update my woke binary.

Issue created as a result of this story. Read this for context: https://github.com/inclusive-dev-tools/woke/issues/13

mkcomer commented 3 years ago

After further investigation, the disableVersionCheck is checking the version of vs-code/woke you are using in your development environment (latest is 0.2.0), not the version of the woke binary.

This functionality works as defined. Closing issue.

However, a useful follow on issue/enhancement could be a version check for the woke binary you are using with your vs-code extension and/or provide instruction/debug with the vs-code extension to update the underlying binary.