incodehq / incode-platform

Combines incode.org modules and isisaddons.org into a single set of modules.
http://platform.incode.org
Apache License 2.0
8 stars 9 forks source link

ApplicationTenancyEvaluator should support i18n #72

Open danhaywood opened 6 years ago

danhaywood commented 6 years ago

rosco [4:28 PM] So it looks like I should make the validateXxx methods return a TranslatableString, and let Isis work its magic with that. However, we implemented an ApplicationTenancyEvaluator for EcpCrm, in which we override the disables() and hides() methods of this interface, which return Strings. How do I handle this, do I call toString() on the TranslatableString before returning it, or will that break translations?

danhaywood [5:25 PM] Yes, that ought to work.

rosco [5:26 PM] Is there a difference for the validateXxx() methods in returning a TranslatableString or returning a toString()

danhaywood [5:26 PM] In general they can return either. Same for hideXxx and disableXxx [5:27 PM] That ApplicationTenancyEvaluator interface is in error really, ought to have been more general. [5:27 PM] (I'll raise a ticket to look into).