incognito1234 / KeePass-Custom-Icon-Dashboarder

KeePass Plugin to download and manage custom icons
Other
67 stars 5 forks source link

Deleting an icon forces the other icons shift. #8

Closed genaDeus closed 1 year ago

genaDeus commented 4 years ago

Deleting an icon with "Remove" action shift/reorder all the icons in the base. Note, if to delete an icon with the standart feature "Edit entry"->Icon->"Icon Picker" all works just fine.

amadeogarcia commented 3 years ago

I also have this issue.

Ookmichiel commented 3 years ago

Same here - I also always use the built-in Icon handler to remove icons

incognito1234 commented 1 year ago

Hi, I was unable to reproduce this issue. Could you give the version of KeePass you use and give a step-by-step plan to reproduce it ? Perhaps the last version of the plugin will solve this issue. Thanks for your feedback, Jareth

amadeogarcia commented 1 year ago

I switched to KeePassXC a long time ago, but I just tried this again (with latest versions of both KeePass and the plugin, i.e. v2.53.1 and v1.3 respectively, as I didn't have them installed anymore) and I'm not sure what the issue was. Sure, it kind of makes all the other icons "shift" as it updates the list after removing one icon, which makes it seem a bit laggy, but that's just how the plugin behaves, even when opening it. Perhaps we could mark this as a performance issue?

Edit: sorry, I forgot the step-by-step. IIRC, and if not then what I just did is wrong, you just go to 'Tools -> Custom Icon Dashboard', select an icon and choose the "Remove" action.

incognito1234 commented 1 year ago

It is indeed the behavior of the plugin. In all cases, icons will shift after a removal as their index is an incremental sequence. I will close this ticket and mark it as a duplicate of issue #7 .