Use `github.com/mattn/go-isatty` for tty detection

inconshreveable / log15

Structured, composable logging for Go

https://godoc.org/github.com/inconshreveable/log15

Other

1.1k stars 145 forks source link

Use `github.com/mattn/go-isatty` for tty detection #130

Closed sean- closed 6 years ago

sean- commented 7 years ago

While at the time there wasn't accepted tty detection code in the wild, mattn's isatty is quite common and well supported. This library already has a dependency on other mattn code. Prefer mattn/go-isatty vs internal terminal code that still has comments referencing go1.3. 😉

Fixes: #115 #129

kevinburke commented 6 years ago

We already have a dependency on this lib via go-colorable, this works for me.

I don't think we should delete the code in term though, as it's a public API. https://godoc.org/github.com/inconshreveable/log15/term?importers

kevinburke commented 6 years ago

Merged as d4e174bf71609b5afbd4a559f7477f370450053d, thanks!