search

inconshreveable / log15

Structured, composable logging for Go
https://godoc.org/github.com/inconshreveable/log15
Other
1.1k stars 145 forks source link

v2.12 Build Issues #139

Open skriptble opened 6 years ago

skriptble commented 6 years ago

Hello, I noticed that a new tag for the v2 branch was created (v2.12), but it was tagged from the master branch not the v2 branch. This has brought in roughly 2 years worth of commits. Was this tag made accidentally?

stgraber commented 6 years ago

Same question here, I just noticed that the v2 branch (which we use through gopkg.in) got a breaking API change, causing build failures on the LXD codebase.

# github.com/lxc/lxd/shared/logging
shared/logging/log_posix.go:16: not enough arguments in call to log15.Must.SyslogHandler
    have (string, log15.Format)
    want (syslog.Priority, string, log15.Format)
shared/logging/log_posix.go:20: not enough arguments in call to log15.Must.SyslogHandler
    have (string, log15.Format)
    want (syslog.Priority, string, log15.Format)
stgraber commented 6 years ago

@inconshreveable any chance you can fix this?

kylechadha commented 6 years ago

👍 +1

We had a breaking build due to the missing stack package:

package gopkg.in/inconshreveable/log15.v2/stack: cannot find package "gopkg.in/inconshreveable/log15.v2/stack" in any of: