search

inconshreveable / log15

Structured, composable logging for Go
https://godoc.org/github.com/inconshreveable/log15
Other
1.1k stars 144 forks source link

Windows newline support #144

Closed MrWaggel closed 1 year ago

MrWaggel commented 6 years ago

Because windows users are people too!

kevinburke commented 6 years ago

Thanks for this and sorry for the delay.

Instead of this can you just define a constant in each file - "\n" for Unix, "\r\n" for Windows - and then write/append the constant from the string? That way we won't need the function call overhead.

kevinburke commented 6 years ago

Also can you rebase against master or merge in master, and squash your commits down to one commit?