move init function to platform-specific file

inconshreveable / log15

Structured, composable logging for Go

https://godoc.org/github.com/inconshreveable/log15

Other

1.1k stars 145 forks source link

move init function to platform-specific file #148

Closed ghost closed 5 years ago

ghost commented 6 years ago

I had initially modified isatty.IsTerminal() for Plan 9 to return false, but that doesn't seem right. The point is that even in terminal windows, escape codes for coloring wouldn't work.

kevinburke commented 6 years ago

Can you be more specific about what breaks? Do you mean to say that Plan 9 does not accept ANSI escape sequences for text written to the terminal?

Can you rebase against master?

ghost commented 6 years ago

Hey Kevin, feel free to close this.

I have abandoned my efforts to port my software to Plan 9. If I ever need this patch again, I can use my own fork... no need to modify the upstream package you own.

In any case, yeah, no escape sequences AFAIK https://news.ycombinator.com/item?id=11883092