search

Incpi / Dark-CPI-Web-Extension

Make themes compatible for SAP CPI
https://i-ncpi.vercel.app/blog/dark-cpi
5 stars 0 forks source link

Text coloring messes with SAP CPI Helper #5

Closed DevGregor closed 4 months ago

DevGregor commented 4 months ago

Describe the bug If you have both CPI Helper (4.0.0) and Dark CPI installed, Dark CPI seems to overwrite some text coloring of the CPI Helper.

To Reproduce Steps to reproduce the behavior:

  1. Install both CPI Helper (4.0.0) and Dark CPI
  2. Check What's New Popup

Expected behavior Some texts and headers are almost not visible unless Dark CPI is turned off.

Screenshots Without Addon: image With Addon: image

Without Addon: image With Addon: image

Desktop (please complete the following information):

Additional context Parts of this issue seem to be related to CPI Helper itself. Will make an issue there as well: https://github.com/dbeck121/CPI-Helper-Chrome-Extension/issues/178

Incpi commented 4 months ago

Hello @DevGregor,

CPI Helper has to be updated to solve this. So, this extension will not be fixed. I left my views on the technical difficulties there.

Thanks, Omkar

DevGregor commented 4 months ago

Hello @incpi

Are you sure? Because some coloring issues in the CPI Helper soley happen by activating this addon. As shown by the screenshots in my first message, these coloring issues are only appearing when activating this addon alongside the CPI Helper. The other issues that exist even without this addon being activated are posted in the other issue.

Incpi commented 4 months ago

Hi @DevGregor,

Would you mind tell me which theme you are utilizing at the time of snapshot. Dark right. Let's Discuss,

Case 1: morning horizon (default theme) or quartz theme, you won't have this issue. I couldn't re-produce what you mentioned with light theme. image image

Case 2: Dark Evening horizon theme. Yes, it has issues with CPI helper. CPI helper lacks in terms of dark theme support.

Yes, I am 100% certain that it has to Fix in Helper. You can also check CSS file in this tool as well. Hope this helps.

DevGregor commented 4 months ago

Hi @DevGregor,

Would you mind tell me which theme you are utilizing at the time of snapshot. Dark right. Let's Discuss,

Case 1: morning horizon (default theme) or quartz theme, you won't have this issue. I couldn't re-produce what you mentioned with light theme. image image

Case 2: Dark Evening horizon theme. Yes, it has issues with CPI helper. CPI helper lacks in terms of dark theme support.

Yes, I am 100% certain that it has to Fix in Helper. You can also check CSS file in this tool as well. Hope this helps.

Okay, then I will close this here. Maybe from testing it has stored white color and sets it as background.