incredibleMachines / 30PP

Player and Uploader App for 30 Park Place
0 stars 0 forks source link

Better Error Handling in FFMPEG #155

Closed piuggi closed 10 years ago

piuggi commented 10 years ago

The ffmpeg module needs to have better error handling in the waterfall to alert us when a process fails during this process. Currently rename process failed and the system was stopped, we would not know about this error if it happened so we should provide better mechanisms for errors and emailing during this process.

jmsaavedra commented 10 years ago

ffmpeg.concat now returns any errors from the waterfall all the way out of the final cb(err).

waterfall is not made of anon functions anymore

commit: https://github.com/incredibleMachines/30PP/commit/e271f4fac34712023174e3bee091df0efa686c7f

jmsaavedra commented 10 years ago

note: commit: e271f4f also replaces fs.rename() with bash mv calls