search

increpare / PuzzleScript

Open Source HTML5 Puzzle Game Engine
MIT License
903 stars 160 forks source link

test cases for error messages #187

Closed rmmh closed 3 years ago

rmmh commented 10 years ago

there should be test cases for the different kinds of compile errors/warnings we expect, and a test failing with an unexpected error should be more obvious

increpare commented 10 years ago

" a test failing with an unexpected error should be more obvious" what do you mean?

On Sun, Apr 27, 2014 at 4:30 PM, Ryan Hitchman notifications@github.comwrote:

there should be test cases for the different kinds of compile errors/warnings we expect, and a test failing with an unexpected error should be more obvious

— Reply to this email directly or view it on GitHubhttps://github.com/increpare/PuzzleScript/issues/187 .

increpare commented 10 years ago

oh, you mean test cases that try to reproduce certain error messages? oh, you're probably right that that'd not be a bad idea. However, vanishing error messages haven't historically been a problem.

On Sun, Apr 27, 2014 at 4:49 PM, Stephen Lavelle analytic@gmail.com wrote:

" a test failing with an unexpected error should be more obvious" what do you mean?

On Sun, Apr 27, 2014 at 4:30 PM, Ryan Hitchman notifications@github.comwrote:

there should be test cases for the different kinds of compile errors/warnings we expect, and a test failing with an unexpected error should be more obvious

— Reply to this email directly or view it on GitHubhttps://github.com/increpare/PuzzleScript/issues/187 .

rmmh commented 10 years ago

Good code that suddenly produces a compile error isn't indicated obviously on the test page. Not sure how hard that would be to do.

I'm thinking tests for things like "object not assigned layer", "duplicate definitions", etc