search

increpare / PuzzleScript

Open Source HTML5 Puzzle Game Engine
MIT License
903 stars 160 forks source link

Don't show mute button if a game doesn't have any sounds/music #449

Closed Draknek closed 6 years ago

Draknek commented 6 years ago

E.g. https://www.puzzlescript.net/play.html?p=0e692c47ab0b18099c2485d644590b4e

This game has no sound effects and no youtube URL, so will never play any audio. It's weird that it still has a mute button.

increpare commented 6 years ago

makes sense!

2018-06-11 13:08 GMT+02:00 Alan Hazelden notifications@github.com:

E.g. https://www.puzzlescript.net/play.html?p= 0e692c47ab0b18099c2485d644590b4e

This game has no sound effects and no youtube URL, so will never play any audio. It's weird that it still has a mute button.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/increpare/PuzzleScript/issues/449, or mute the thread https://github.com/notifications/unsubscribe-auth/AAca4LqktaMQRMwgQfAQ5tyZxXpdgSt4ks5t7k-_gaJpZM4Uif2g .