increpare / PuzzleScript

Open Source HTML5 Puzzle Game Engine
MIT License
903 stars 160 forks source link

Editor's test window is inconsistent with what actually happens. #484

Closed edderiofer closed 3 years ago

edderiofer commented 6 years ago

In this project, pressing X then up has a different behaviour depending on whether you're in the editor or if you're on the game page.

increpare commented 6 years ago

oh geeze it sure does. thanks for letting me know. if you could make an even simpler example reproduction example that would help, otherwise, I'll try to get around to it sooner rather than later.

(i hope this isn't blocking you right now? if so let me know and I'll push it up to tip-top priority)

2018-08-05 16:12 GMT+02:00 edderiofer notifications@github.com:

In this project https://www.puzzlescript.net/play.html?p=3a7d1951661b29327b0e4d2dd6c7eed3, pressing X then up has a different behaviour depending on whether you're in the editor or if you're on the game page.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/increpare/PuzzleScript/issues/484, or mute the thread https://github.com/notifications/unsubscribe-auth/AAca4DyL-gINqCbtd36Pxw4W4_4_UolCks5uNv1PgaJpZM4VvZMF .

increpare commented 6 years ago

OH, spooky, I think i know what the problem is. If in the editor after moving, you resize the browser window, does the display update and correct itself? it looks like it might be forgetting to redraw itself for some reason

2018-08-06 1:26 GMT+02:00 Stephen Lavelle analytic@gmail.com:

oh geeze it sure does. thanks for letting me know. if you could make an even simpler example reproduction example that would help, otherwise, I'll try to get around to it sooner rather than later.

(i hope this isn't blocking you right now? if so let me know and I'll push it up to tip-top priority)

2018-08-05 16:12 GMT+02:00 edderiofer notifications@github.com:

In this project https://www.puzzlescript.net/play.html?p=3a7d1951661b29327b0e4d2dd6c7eed3, pressing X then up has a different behaviour depending on whether you're in the editor or if you're on the game page.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/increpare/PuzzleScript/issues/484, or mute the thread https://github.com/notifications/unsubscribe-auth/AAca4DyL-gINqCbtd36Pxw4W4_4_UolCks5uNv1PgaJpZM4VvZMF .

increpare commented 6 years ago

question 2: does commenting out "verbose_logging" fix the behaviour for you?

2018-08-06 1:29 GMT+02:00 Stephen Lavelle analytic@gmail.com:

OH, spooky, I think i know what the problem is. If in the editor after moving, you resize the browser window, does the display update and correct itself? it looks like it might be forgetting to redraw itself for some reason

2018-08-06 1:26 GMT+02:00 Stephen Lavelle analytic@gmail.com:

oh geeze it sure does. thanks for letting me know. if you could make an even simpler example reproduction example that would help, otherwise, I'll try to get around to it sooner rather than later.

(i hope this isn't blocking you right now? if so let me know and I'll push it up to tip-top priority)

2018-08-05 16:12 GMT+02:00 edderiofer notifications@github.com:

In this project https://www.puzzlescript.net/play.html?p=3a7d1951661b29327b0e4d2dd6c7eed3, pressing X then up has a different behaviour depending on whether you're in the editor or if you're on the game page.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/increpare/PuzzleScript/issues/484, or mute the thread https://github.com/notifications/unsubscribe-auth/AAca4DyL-gINqCbtd36Pxw4W4_4_UolCks5uNv1PgaJpZM4VvZMF .

edderiofer commented 6 years ago

Yes on both counts.

increpare commented 3 years ago

seems to magically work for me now. closing. (tested on chrome and firefox).

Thanks again for the report!