search

increpare / PuzzleScript

Open Source HTML5 Puzzle Game Engine
MIT License
903 stars 159 forks source link

The editor palette doesn't appear when first opened #54

Closed Draknek closed 10 years ago

Draknek commented 10 years ago

The first time you open the editor, the list of tiles at the top doesn't appear. You have to close and re-open edit mode to see them.

This also happens when you resize the level and that makes the game's scale change.

increpare commented 10 years ago

I can't repro this. What browser/os are you using?

On Wed, Feb 19, 2014 at 3:03 PM, Alan Hazelden notifications@github.comwrote:

The first time you open the editor, the list of tiles at the top doesn't appear. You have to close and re-open edit mode to see them.

This also happens when you resize the level and that makes the game's scale change.

Reply to this email directly or view it on GitHubhttps://github.com/increpare/PuzzleScript/issues/54 .

Draknek commented 10 years ago

Happens for me reliably in both Firefox and Chrome (Linux).

diribative commented 10 years ago

I also had this problem on Firefox on Windows 8.

increpare commented 10 years ago

Still can't repro it - removing it from the 1.4 milestone. The problems should all be self-contained within (or traceable from) graphics.js -my guess would be something's going wrong with canvasresize (which generates bitmaps of the right size when you resize the window/change the width/height of the play area/open the editor/&c.)

increpare commented 10 years ago

The lovely Alan wants pressure to do this, so putting it back on 1.4 milestone. GET TO IT ALAN.

increpare commented 10 years ago

ONLY THIS BUG LEFT man.

mechturk commented 10 years ago

I'm not sure if this fixes the bug as I can't reproduce it, but canvas.style.height and canvas.style.width were being passed raw ints whereas style requires strings. e.g. "512px".

Draknek commented 10 years ago

Good news! This seems to have at some point been fixed accidentally :)

increpare commented 10 years ago

oh no, zero bugs. want to make one game with it before pushing it live.

On Wed, Apr 16, 2014 at 6:07 PM, Alan Hazelden notifications@github.comwrote:

Good news! This seems to have at some point been fixed accidentally :)

— Reply to this email directly or view it on GitHubhttps://github.com/increpare/PuzzleScript/issues/54#issuecomment-40625063 .