search

increpare / PuzzleScript

Open Source HTML5 Puzzle Game Engine
MIT License
903 stars 159 forks source link

win condition ignored if run in run_rules_on_level_start #578

Closed increpare closed 3 years ago

increpare commented 3 years ago

https://www.puzzlescript.net/play.html?p=d5e23f75865be5a5ff54387491bf60f9

I think this is actually ok, but I should adjust the debugging message in this case.

increpare commented 3 years ago

brought to my attention in #574

chz16 commented 3 years ago

The use case would be cutscene levels that play entirely without player interaction, which I have in a few of my games. I've always done it with animations and having the win come in an again turn though, I don't know if it ever worked on the initial execution turn. If it was always like this and wasn't recently broken like the other thing, then I guess it's not a pressing issue haha

increpare commented 3 years ago

Ah yeah, fair thoughts! Thanks for sharing. That's a possible use case; the sort of thing that maybe vexd edit or the like used. It's as likely games rely on the existing behaviour as would want it otherwise though, and I'm not particular sure I want to go out of my way to cater to either use-case ^_^

chz16 commented 3 years ago

Yeah, if that's how it always worked then you can go ahead and disregard this. I just ran into it while testing the other thing and assumed that it was also a recent regression.