increpare / PuzzleScript

Open Source HTML5 Puzzle Game Engine
MIT License
903 stars 160 forks source link

Can't use "sfx" with "cancel" #61

Closed musurca closed 7 years ago

musurca commented 10 years ago

Attempting to pair the "cancel" keyword with a "sfx" keyword gives the following error: "The CANCEL command can only appear by itself on the right hand side of the arrow."

Since "cancel" is often used to block illegal moves, it seems like it would be useful to allow some kind of feedback sound to alert the player. Why not allow "sfx" (and maybe even "message") to be the exception to this rule?

Thanks!

increpare commented 10 years ago

good point! I don't know. I'll think about it, but don't expect immediate action.

On Tue, Mar 4, 2014 at 7:42 PM, musurca notifications@github.com wrote:

Attempting to pair the "cancel" keyword with a "sfx" keyword gives the following error: "The CANCEL command can only appear by itself on the right hand side of the arrow."

Since "cancel" is often used to block illegal moves, it seems like it would be useful to allow some kind of feedback sound to alert the player. Why not allow "sfx" (and maybe even "message") to be the exception to this rule?

Thanks!

Reply to this email directly or view it on GitHubhttps://github.com/increpare/PuzzleScript/issues/61 .

musurca commented 10 years ago

No worries. I should add that the other possible way to solve this would be to add a special "CANCEL 0123456" item in the Sound section. (Although this strikes me as a bit of a kludge since I can imagine wanting certain rules to fail silently and others to fail audibly within the same script.)

On Tue, Mar 4, 2014 at 1:17 PM, increpare notifications@github.com wrote:

good point! I don't know. I'll think about it, but don't expect immediate action.

On Tue, Mar 4, 2014 at 7:42 PM, musurca notifications@github.com wrote:

Attempting to pair the "cancel" keyword with a "sfx" keyword gives the following error: "The CANCEL command can only appear by itself on the right hand side of the arrow."

Since "cancel" is often used to block illegal moves, it seems like it would be useful to allow some kind of feedback sound to alert the player. Why not allow "sfx" (and maybe even "message") to be the exception to this rule?

Thanks!

Reply to this email directly or view it on GitHub< https://github.com/increpare/PuzzleScript/issues/61> .

Reply to this email directly or view it on GitHubhttps://github.com/increpare/PuzzleScript/issues/61#issuecomment-36678815 .

increpare commented 10 years ago

Just making a note - note sure if/how I want to solve this yet. Going to sit on it for a while longer.

Draknek commented 10 years ago

Not sure if this has always been the behaviour, but currently, if you use the cancel command it will play the "undo" sound effect.

I am mostly happy with this I think, it is better than not being able to play sounds on player input that doesn't do anything (but a distinct sound trigger for cancel would probably be nicer).

increpare commented 10 years ago

That sounds like a bug - I might fix it in future.

On Mon, Jun 9, 2014 at 11:50 PM, Alan Hazelden notifications@github.com wrote:

Not sure if this has always been the behaviour, but currently, if you use the cancel command it will play the "undo" sound effect.

I am mostly happy with this I think, it is better than not being able to play sounds on player input that doesn't do anything (but a distinct sound trigger for cancel would probably be nicer).

— Reply to this email directly or view it on GitHub https://github.com/increpare/PuzzleScript/issues/61#issuecomment-45554358 .

Draknek commented 10 years ago

Probably related to #223?

If you do fix it, please add a "cancel" sound trigger! I think the worry above about "wanting certain rules to fail silently and others to fail audibly within the same script" is not a strong argument against.

On Sticky Candy Puzzle Saga I avoided using cancel and manually prevented input from doing anything so I could play a can't-move sound when pushing candy into walls but this is (A) awkward and (B) really really hard for some games.

increpare commented 7 years ago

added a 'cancel' sfx trigger now if you really want it.