search

increpare / PuzzleScript

Open Source HTML5 Puzzle Game Engine
MIT License
903 stars 159 forks source link

cf "Fix a bug allowing a tag completion to double an entry if it matches a valid object name." #712

Closed increpare closed 3 years ago

increpare commented 3 years ago

https://github.com/ClementSparrow/Pattern-Script/commit/bce5a8640ba19949db881aa3188275dd492d72a4

ClementSparrow commented 3 years ago

The bug concerned the tag system that I introduced in the fork (the syntax Object:tag), so I doubt the problem exists also in vanilla PuzzleScript.

PS: I'm not used to work on forks, so please tell me if I can do anything to help you.

increpare commented 3 years ago

Ah ok, I just look through your changes sometimes and make a note for future purposes if there's anything that might be interesting, but I didn't look at this one closely enough. Thanks for the clarification :)

Honestly it's just nice to see someone doing such a huge volume of work with puzzlescript - it's motivating me a bit to keep work up on the main branch :) (also to see how you're re-architecting the engine is interesting!)

I'd say, one thing you could do, if you do fix bugs locally that're likely to be in the main branch, or other small tweaks, just cc me @increpare so I don't miss it (ideally describing what the bug is ^^ ).

ClementSparrow commented 3 years ago

I'd say, one thing you could do, if you do fix bugs locally that're likely to be in the main branch, or other small tweaks, just cc me @increpare so I don't miss it (ideally describing what the bug is ^^ ).

OK, I will do that. For the tweaks, I will try to submit directly a pull request if it's not too much work for me to make one, otherwise I will @ you in a comment for the commit, with an explanation.

increpare commented 3 years ago

Cool, thanks :)

Am Mi., 11. Aug. 2021 um 12:29 Uhr schrieb ClementSparrow < @.***>:

I'd say, one thing you could do, if you do fix bugs locally that're likely to be in the main branch, or other small tweaks, just cc me @increpare https://github.com/increpare so I don't miss it (ideally describing what the bug is ^^ ).

OK, I will do that. For the tweaks, I will try to submit directly a pull request if it's not too much work for me to make one, otherwise I will @ you in a comment for the commit, with an explanation.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/increpare/PuzzleScript/issues/712#issuecomment-896706542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADRVYFUQMSZHKFFG2SUHVTT4JGJZANCNFSM5B544IEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .