increpare / PuzzleScript

Open Source HTML5 Puzzle Game Engine
MIT License
896 stars 157 forks source link

A PS+ fix that should be in the vanilla version too #943

Open Stingby12 opened 1 year ago

Stingby12 commented 1 year ago

I don't know about you but I keep thinking that the massive space between the toolbar and the main window should be fixed just like in PuzzleScript+.

Vanilla PuzzleScript : image

PuzzleScript+ : image

I think this wasn't actually an issue in an early version of that engine, but it would be nice if this was fixed.

increpare commented 1 year ago

Hello, thanks for the report. I can't get the editor toolbar to wander too far from the level. I need some more information from you. Could you

1: give me a link to source code that exhibits the behaviour you're describing. 2: let me know what browser / operating system you're using. 3: give an uncropped screenshot of the whole browser window.

Stingby12 commented 1 year ago

The link leads to a puzzle game I'm working on, it will take some time to get on my itch.io account. There are so far 3 sections.

Anyways, here you can see what the level editor looks like in vanilla PuzzleScript : https://www.puzzlescript.net/editor.html?hack=8ab89a3cb97a4a9a3f6473bc8a80cbe0

And here it's what it looks like in PuzzleScript+ : https://auroriax.github.io/PuzzleScript/editor.html?hack=5239075901fbe8a8c7436c376d7d6547

It's basically the same thing if you take a random game made with vanilla PuzzleScript, copy his code and put it on PuzzleScript+.

increpare commented 1 year ago

Ok, I found the bug I think - just playing in the editor it looks like it's allocating screen space based on the number of raw sprites defined rather than the number of indexed object to be placed in the legend

e.g. here

https://www.puzzlescript.net/editor.html?hack=db498485749a9792ebbfa28b23a91e4d

Bildschirmfoto 2022-09-26 um 23 21 47

Should be easy enough for me to fix - thanks for alerting my attention!