Open increpare opened 4 months ago
Are there tests in the test suite for all these fixes?
Regards
David M Bennett FACS
Polyomino Games – Programming Languages and Players for Games and Puzzles -- http://www.polyomino.com http://www.polyomino.com/
From: increpare @.> Sent: Saturday, 27 April 2024 9:27 AM To: increpare/PuzzleScript @.> Cc: Subscribed @.***> Subject: [increpare/PuzzleScript] syntax highlighter chokes on line starting with ") ====" but compiler understands it... (Issue #997)
Bildschirmfoto.2024-04-27.um.01.26.17.png (view on web) https://github.com/increpare/PuzzleScript/assets/465632/c0a02c98-0148-44b5-b996-b6d46c7c0374
not sure what the desired behaviour is - doing nothing seems good enough more or less, but some message might be good 😅
— Reply to this email directly, view it on GitHub https://github.com/increpare/PuzzleScript/issues/997 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBMEXJ45OJM4SJJ5FNZY33Y7LPFTAVCNFSM6AAAAABG3RXRZCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DMNRSGI2DAOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Assuming you're talking about the other small bug-fixes from yesterday? Tests only cover core compiler/engine behaviour. Anything beyond (interface bugs, networking) that gets hairy very fast. Let's look at the last four code fixes.
The game engine is complex and it's very easy to break things accidentally when fixing other things (regressions would definitely happen regularly when fixing compiler bugs if I didn't have a test suite). The things mentioned above, while they could break (and while I do occasionally break things), just don't carry the same risk. Also, making tests for the engine/compiler is very easy, and writing tests for each the above would be much more involved (and they would be likely much more fragile).
All I can really say is it's a shame. The one thing a long-lived product like PS really deserves is a comprehensive test suite that nails its specified behaviour and can be used to check for bugs and regressions. SQLite is my go-to example.
not sure what the desired behaviour is - doing nothing seems good enough more or less, but some message might be good 😅