Closed n-oden closed 3 days ago
@incu6us I've updated this against current upstream/master and fixed the conflict
Attention: Patch coverage is 0%
with 99 lines
in your changes missing coverage. Please review.
Project coverage is 57.00%. Comparing base (
da1c44e
) to head (add3bec
). Report is 5 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
main.go | 0.00% | 99 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Is the codecov test advisory, or are you asking for test coverage going forward? There's no current test set for main.go, but I suppose we could make one...
@incu6us I've updated this against current upstream/master and fixed the conflict
@n-oden could you update it once again?
@incu6us @ccoVeille addressed the comments, rebased on current upstream/master, and while I was at it spotted another issue: the call to helper.DetermineProjectName needed to be moved inside the loop over originPaths
since different paths might have different project names.
Great. Let's waif for @incu6us feedbacks then
thanks @n-oden for your help. I have no any additional comments. agree with @ccoVeille about his comments to make some things more readable and simpler.
Thanks to all of you for getting my PRs merged and released!
This addresses https://github.com/incu6us/goimports-reviser/issues/96
iterate over the list of remaining arguments treating each as an origin path
defer printing deprecation warnings until after all paths are processed
print deprecation warnings to stderr, not stdout