incu6us / goimports-reviser

Right imports sorting & code formatting tool (goimports alternative)
MIT License
607 stars 72 forks source link

Allow multiple targets on command line #160

Closed n-oden closed 3 days ago

n-oden commented 4 months ago

This addresses https://github.com/incu6us/goimports-reviser/issues/96

n-oden commented 4 days ago

@incu6us I've updated this against current upstream/master and fixed the conflict

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 99 lines in your changes missing coverage. Please review.

Project coverage is 57.00%. Comparing base (da1c44e) to head (add3bec). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
main.go 0.00% 99 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #160 +/- ## ========================================== + Coverage 55.34% 57.00% +1.66% ========================================== Files 11 11 Lines 1104 1177 +73 ========================================== + Hits 611 671 +60 - Misses 470 482 +12 - Partials 23 24 +1 ``` | [Flag](https://app.codecov.io/gh/incu6us/goimports-reviser/pull/160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Viacheslav+Pryimak) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/incu6us/goimports-reviser/pull/160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Viacheslav+Pryimak) | `57.00% <0.00%> (+1.66%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Viacheslav+Pryimak#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

n-oden commented 4 days ago

Is the codecov test advisory, or are you asking for test coverage going forward? There's no current test set for main.go, but I suppose we could make one...

incu6us commented 3 days ago

@incu6us I've updated this against current upstream/master and fixed the conflict

@n-oden could you update it once again?

n-oden commented 3 days ago

@incu6us @ccoVeille addressed the comments, rebased on current upstream/master, and while I was at it spotted another issue: the call to helper.DetermineProjectName needed to be moved inside the loop over originPaths since different paths might have different project names.

ccoVeille commented 3 days ago

Great. Let's waif for @incu6us feedbacks then

incu6us commented 3 days ago

thanks @n-oden for your help. I have no any additional comments. agree with @ccoVeille about his comments to make some things more readable and simpler.

n-oden commented 3 days ago

Thanks to all of you for getting my PRs merged and released!