search

incuna / angular-input-fields

Angular library for common input fields
MIT License
2 stars 0 forks source link

Initial setup #1

Closed wytrych closed 8 years ago

wytrych commented 9 years ago

@maxpeterson @grahamgilchrist @henrahmagix @Minglee01 Please take a look at this new repo. Any suggestions welcome.

Minglee01 commented 9 years ago

It looks ok. But maybe split the directives into seperate files.

On 25 August 2015 at 09:52, Marcin Wolniewicz notifications@github.com wrote:

@maxpeterson https://github.com/maxpeterson @grahamgilchrist https://github.com/grahamgilchrist @henrahmagix https://github.com/henrahmagix @Minglee01 https://github.com/Minglee01 Please take a look at this new repo. Any suggestions welcome.

— Reply to this email directly or view it on GitHub https://github.com/incuna/angular-input-fields/issues/1.

Ming Lee - Junior Frontend ProgrammerMing@incuna.com 01865 791 494 Incuna Ltd, 16 Middle Way, Oxford, OX2 7LH

henrahmagix commented 9 years ago

Do all the templates need the -input suffix?

henrahmagix commented 9 years ago

switch-input has a dependency on angular-bootstrap but bower.json doesn't mark it as a dependency. See btn-radio directive used here https://github.com/incuna/angular-input-fields/blob/59a875a8a30332a65fce9a201c289fb227f0cbb6/src/templates/type/switch-input.html#L3

grahamgilchrist commented 9 years ago

Yeah, would good to seperate each directive to it's own file to help readability, merging, choice of import etc.

grahamgilchrist commented 8 years ago

Moved issue to split modules in #12, so closing this issue

grahamgilchrist commented 8 years ago

Issue to add bower bootstrap dependency added in #11