search

incuna / angular-input-fields

Angular library for common input fields
MIT License
2 stars 0 forks source link

Register each directive in a speparate module #16

Closed wytrych closed 8 years ago

wytrych commented 8 years ago

@incuna/js please review

wytrych commented 8 years ago

PLEASE NOT MERGE YET

wytrych commented 8 years ago

@incuna/js Ready for review

henrahmagix commented 8 years ago

@wytrych This works but is untenable, considering the nature of the error you encountered and the fact that every module independently depends on all the modules' templates.

I think the best thing to do would be to fully split them into separate modules – files, folders, everything – and compile templates for each one. You can still have angular-input-fields.js as a single entry point by using grunt-contrib-concat to combine every module into one file.

wytrych commented 8 years ago

@henrahmagix Please re-review

wytrych commented 8 years ago

@henrahmagix Anything else?

wytrych commented 8 years ago

Fix #4

henrahmagix commented 8 years ago

Would be nice to have #17 after this

wytrych commented 8 years ago

@henrahmagix Updated

wytrych commented 8 years ago

Forgot sth

wytrych commented 8 years ago

Ok

henrahmagix commented 8 years ago

:+1:

wytrych commented 8 years ago

@henrahmagix Can we merge as is?

wytrych commented 8 years ago

Thanks!