add option to add id and name to select template

incuna / angular-input-fields

Angular library for common input fields

MIT License

2 stars 0 forks source link

add option to add id and name to select template #32

Closed hippogriffic closed 8 years ago

hippogriffic commented 8 years ago

@incuna/frontend please review

wytrych commented 8 years ago

Cool. You might want to wait with release as you might discover you need that for something else too

hippogriffic commented 8 years ago

good thinking, I will use the commit for now

hippogriffic commented 8 years ago

actually it would probably be a good idea to add this option to all the field types... someday

hippogriffic commented 8 years ago

uh oh @wytrych travis is angry :(

wytrych commented 8 years ago

Oh wow that's bizzare

wytrych commented 8 years ago

It might be that there were some changes in the newest angular? I'll take a look, you can still use the commit in your project though even if unmerged

hippogriffic commented 8 years ago

ok thanks

pandalion commented 8 years ago

@wytrych can this be merged? :)