search

incuna / angular-input-fields

Angular library for common input fields
MIT License
2 stars 0 forks source link

Namespace the templates to this module via a folder #4

Closed henrahmagix closed 8 years ago

henrahmagix commented 9 years ago

templates/type/my-input.html should be templates/angular-input-fields/type/my-input.html so that a project with a templates path of type/ doesn't get clobbered by this library, or vice versa: this library doesn't clobber a project's type/ templates path.

This will be a breaking change.

henrahmagix commented 9 years ago

This should complete the filesystem part of the issue:

mkdir src/templates/angular-input-fields
git mv src/templates/* src/templates/angular-input-fields/

And then find-replace

s/templates\/type/templates\/angular-input-fields\/type/g
grahamgilchrist commented 9 years ago

Good idea

wytrych commented 8 years ago

@grahamgilchrist It would really nice this one

henrahmagix commented 8 years ago

Fixed by #16

@wytrych If you edit a pull-request's description (first comment) and put Fix #4 in there, it will automatically close this issue once the pull-request is merged (if it's being merged into the default branch).