search

incuna / angular-input-fields

Angular library for common input fields
MIT License
2 stars 0 forks source link

Refactor and dont pad the value #7

Closed wytrych closed 9 years ago

wytrych commented 9 years ago

This is for the earlier PR, changed it to a filter after all to not mess with the value of the option.

wytrych commented 9 years ago

@grahamgilchrist @henrahmagix This should be a better soultion

henrahmagix commented 9 years ago

This is for the earlier PR

For #6?

wytrych commented 9 years ago

@henrahmagix Done, can we get this merged? I added a few tests, and yes you can add for the same things 6 tests or 64 tests, but when doing TDD I only add the tests that I need, so I think there must be a limit to how many you want to add.

henrahmagix commented 9 years ago

Of course, I don't mean to add a number test for every string test, nor to add a test for every number from 0 to some arbitrary number. Just some extra tests to ensure the filter runs as intended is enough.

wytrych commented 9 years ago

Thanks!