search

incuna / django-user-management

User management model mixins and api views.
BSD 2-Clause "Simplified" License
57 stars 24 forks source link

Add `incuna-pigeon` to send notifications #107

Closed kevinetienne closed 9 years ago

kevinetienne commented 9 years ago

It looks like we have two different behaviors to send emails in django-user-management. In some places we are sending html and text emails and in PasswordReset we only send html emails.

Using incuna-pigeon would make sending emails behaving the same accross the project and would allow apps using django-user-management to customise handlers to send emails.

As this project is compatible with django1.6 and 1.7, I think it makes sense to define the notification handlers in settings.

meshy commented 9 years ago

:+1:

kevinetienne commented 9 years ago

Not yet ready still need a setting to use a custom Notification

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 280d59592d387e13eb3f49eca21d1c281ba874c4 on use-incuna-pigeon into be3ca0a4c63b0221e16659800c90831d69781978 on master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e2387e6c5265cb2fbe405df1277afb0807da6230 on use-incuna-pigeon into be3ca0a4c63b0221e16659800c90831d69781978 on master.

kevinetienne commented 9 years ago

Updated

kevinetienne commented 9 years ago

Updated

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ca69ca8f6fed57ff7b20d193c321f8da797ef063 on use-incuna-pigeon into be3ca0a4c63b0221e16659800c90831d69781978 on master.

kevinetienne commented 9 years ago

Don't merge yet I've spotted an error in the templates

kevinetienne commented 9 years ago

Templates have been updated

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0c6ff45ccbe5540860015a900cc77b0bafd31ab5 on use-incuna-pigeon into 6e4d651ed269a86a3ae16b6cfef14f612e73341c on master.