Closed kevinetienne closed 9 years ago
I also like this, as it stops changes to the fields from accidentally propagating up the tree of subclasses.
Ready for review/merge. Not sure if it was a breaking change but it looks like project sub-classing RegistrationSerializer.Meta.fields
might get an error (when concatenated with something other than a tuple).
@KevinEtienne I agree, frustrating as it is, I think this does count as a breaking change. It might be worth expanding on the changelog to briefly explain how to migrate to this version.
Cool thanks, I'll do that
Updated, @Ian-Foote @adam-incuna can you review/merge please?
:+1:
Thanks :)
If in a project we define a tuple of core fields and try to concatenate them with the original serializer fields we need to add an exception to
RegistrationSerializer
.Making all fields a tuple allow to subclass them more easily.